-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Lock] remove deprecated Factory for LockFactory #32495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Simperfit
wants to merge
1
commit into
symfony:master
from
Simperfit:feature/remove-Factory-for-LockFactory
Closed
[Lock] remove deprecated Factory for LockFactory #32495
Simperfit
wants to merge
1
commit into
symfony:master
from
Simperfit:feature/remove-Factory-for-LockFactory
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
xabbuh
reviewed
Jul 13, 2019
af09f0f
to
eb5d06c
Compare
xabbuh
approved these changes
Jul 13, 2019
eb5d06c
to
8bd805a
Compare
jderusse
reviewed
Jul 18, 2019
/** | ||
* @author Jérémy Derussé <jeremy@derusse.com> | ||
*/ | ||
class FactoryTest extends TestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be reverted (and renamed into LockFactoryTest
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the deprecated Factory and changes the alias in FrameworkBundle.