Skip to content

[Validator] Add german translation for Range validator #32518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2019
Merged

[Validator] Add german translation for Range validator #32518

merged 1 commit into from
Jul 12, 2019

Conversation

PReimers
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

German translation for #32435

@PReimers PReimers changed the title Add german translation for Range validator [Validator] Add german translation for Range validator Jul 12, 2019
@Lctrs
Copy link
Contributor

Lctrs commented Jul 12, 2019

Should target 3.4.

@fabpot fabpot changed the base branch from 4.4 to 3.4 July 12, 2019 11:07
@fabpot
Copy link
Member

fabpot commented Jul 12, 2019

Thank you @PReimers.

@fabpot fabpot merged commit d392e49 into symfony:3.4 Jul 12, 2019
fabpot added a commit that referenced this pull request Jul 12, 2019
…PReimers)

This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead (closes #32518).

Discussion
----------

[Validator] Add german translation for Range validator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

German translation for #32435

Commits
-------

d392e49 Add german translation for Range validator
@PReimers
Copy link
Contributor Author

@Lctrs, @fabpot the related PR #32435 is targeting 4.4.

Why should this translation target 3.4?

@fabpot
Copy link
Member

fabpot commented Jul 12, 2019

@PReimers We merge all translations back in 3.4 to ease maintenance on our side.

@PReimers
Copy link
Contributor Author

@fabpot Thanks for the explanation. Didn't know this. 👍

@xabbuh xabbuh added this to the 3.4 milestone Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants