Container*::getServiceIds() should return strings #32563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as a bug fix this would need to be in 3.4 |
ro0NL
reviewed
Jul 16, 2019
| @@ -324,7 +324,7 @@ public function reset() | |||
| */ | |||
| public function getServiceIds() | |||
| { | |||
| return array_unique(array_merge(['service_container'], array_keys($this->fileMap), array_keys($this->methodMap), array_keys($this->services))); | |||
| return array_map(function($id) { return (string) $id;}, array_unique(array_merge(['service_container'], array_keys($this->fileMap), array_keys($this->methodMap), array_keys($this->services)))); | |||
There was a problem hiding this comment.
array_map('strval', ...)
0699716 to
be9c0fb
Compare
|
thank for the review. I've rebased on 3.4 and address the comments here, let me know if anything else is needed |
phansys
approved these changes
Jul 16, 2019
nicolas-grekas
approved these changes
Jul 16, 2019
derrabus
approved these changes
Jul 16, 2019
xabbuh
approved these changes
Jul 16, 2019
Simperfit
approved these changes
Jul 17, 2019
fabpot
approved these changes
Jul 17, 2019
|
Thank you @mathroc. |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Container*::getServiceIds() should return strings | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | o | Tests pass? | yes | Fixed tickets | #32549 | License | MIT Cast services ids to string in `Container*::getServiceIds()` Commits ------- 9c88caa Container*::getServiceIds() should return an array of string
Merged
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast services ids to string in
Container*::getServiceIds()