Skip to content

[TwigBundle] Remove useless "format" attribute #32694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jul 23, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR not needed

spotted in #31398 (comment)

@Tobion
Copy link
Contributor

Tobion commented Jul 24, 2019

I don't think we should remove that in a patch version as it might be used within a custom $this->controller

@fabpot
Copy link
Member

fabpot commented Jul 24, 2019

That's a BC break.

@fabpot fabpot closed this Jul 24, 2019
@yceruto yceruto deleted the twig_bundle_cleanup branch July 24, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants