[WebProfilerBundle] Decoupling TwigBundle and using the new ErrorRenderer mechanism #32695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yceruto
commented
Jul 24, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #31398 (comment) |
| License | MIT |
| Doc PR | - |
fabpot
approved these changes
Jul 24, 2019
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Jul 24, 2019
…e new ErrorRenderer mechanism (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] Decoupling TwigBundle and using the new ErrorRenderer mechanism | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #31398 (comment) | License | MIT | Doc PR | - Commits ------- 846d3e0 Decoupling TwigBundle and using the new ErrorRenderer mechanism
stof
reviewed
Jul 24, 2019
| @@ -27,7 +27,13 @@ | |||
| <argument type="service" id="twig" /> | |||
| <argument>%kernel.debug%</argument> | |||
| <argument type="service" id="debug.file_link_formatter" /> | |||
| <argument type="service" id="error_renderer.renderer.html" on-invalid="null" /> | |||
| <argument type="service" id="error_renderer.renderer.html" /> | |||
There was a problem hiding this comment.
It's a hard dependency on the bundle since 4.4, is there any chance it's invalid?
Tobion
reviewed
Jul 24, 2019
src/Symfony/Bundle/WebProfilerBundle/Controller/ExceptionErrorController.php
Show resolved
Hide resolved
Tobion
reviewed
Jul 24, 2019
src/Symfony/Bundle/WebProfilerBundle/Controller/ExceptionErrorController.php
Show resolved
Hide resolved
Tobion
reviewed
Jul 24, 2019
Tobion
added a commit
that referenced
this pull request
Jul 25, 2019
…and mark it as internal (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] Rename the new exception controller and mark it as internal | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32695 (comment) | License | MIT | Doc PR | - I missed some important details in #32695 Commits ------- ba24a51 Rename the new exception controller and mark it as internal
Tobion
added a commit
that referenced
this pull request
Jul 25, 2019
…precated templates (yceruto) This PR was squashed before being merged into the 5.0-dev branch (closes #32714). Discussion ---------- [TwigBundle] Add missing CHANGELOG entries and remove deprecated templates | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up #32696, Require merge 4.4 into master after #32695 to make WebProfilerBundle work properly in master. Commits ------- 0222860 [TwigBundle] Add missing CHANGELOG entries and remove deprecated templates
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.