[HttpClient] add "max_duration" option #32807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fancyweb
commented
Jul 30, 2019
•
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #32765 |
| License | MIT |
| Doc PR | symfony/symfony-docs#12073 |
fancyweb
commented
Jul 30, 2019
28d6033 to
f8595d1
Compare
f8595d1 to
b557ca9
Compare
lyrixx
reviewed
Jul 30, 2019
c5bfb73 to
85fc4fa
Compare
55c3b79 to
fd5ce76
Compare
c45f257 to
0666c84
Compare
bc7bead to
6b62a10
Compare
6b62a10 to
9aadadc
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 31, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Contracts] Fix branch alias | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted in #32807 Commits ------- 05cfc2b [Contracts] Fix branch alias
9aadadc to
57ed726
Compare
nicolas-grekas
approved these changes
Jul 31, 2019
|
Shouldn't we allow configuring the option in frameworkbundle? |
57ed726 to
15fbf60
Compare
fancyweb
commented
Aug 1, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
97a3aac to
37b47ed
Compare
37b47ed to
a4178f1
Compare
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 6, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] add "max_duration" option | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32765 | License | MIT | Doc PR | symfony/symfony-docs#12073 Commits ------- a4178f1 [HttpClient] add "max_duration" option
|
Awesome! Thank you @fancyweb |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 15, 2019
…ancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][HttpClient] "max_duration" option Doc for symfony/symfony#32807 Commits ------- a0e1776 [FrameworkBundle][HttpClient] "max_duration" option
This was referenced Nov 12, 2019
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 17, 2022
…colas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Add missing HttpOptions::setMaxDuration() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | no Forgotten in #32807 Commits ------- 54d442a [HttpClient] Add missing HttpOptions::setMaxDuration()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.