Skip to content

[PhpUnitBridge] Remove deprecated methods assertArraySubset #32909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2019

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Aug 3, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32844
License MIT
Doc PR

This PR removes the 2 occurrences of assertArraySubset

@jderusse jderusse force-pushed the deprec-assertArraySubset branch from 1664cec to 114ec6c Compare August 3, 2019 17:56
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 3, 2019
@nicolas-grekas nicolas-grekas mentioned this pull request Aug 3, 2019
23 tasks
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 114ec6c into symfony:3.4 Aug 3, 2019
nicolas-grekas added a commit that referenced this pull request Aug 3, 2019
…set (jderusse)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Remove deprecated methods assertArraySubset

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        |

This PR removes the 2 occurrences of assertArraySubset

Commits
-------

114ec6c Remove deprecated methods assertArraySubset
@jderusse jderusse changed the title [PhpUnitBridge] Remove deprecated methods assertArraySubset WIP [PhpUnitBridge] Remove deprecated methods assertArraySubset Aug 4, 2019
@jderusse jderusse changed the title WIP [PhpUnitBridge] Remove deprecated methods assertArraySubset [PhpUnitBridge] Remove deprecated methods assertArraySubset Aug 4, 2019
@jderusse jderusse deleted the deprec-assertArraySubset branch August 8, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants