Use assertStringContainsString when needed #32971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix tests in #32972 |
fabpot
added a commit
that referenced
this pull request
Aug 6, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [PHPUnitBridge] Fix name of logical classes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32971 | License | MIT | Doc PR | NA In PHPUnit, class name of logical constaint (and, or, not, ...) does not respect the same pattern than classes Commits ------- e2c847f Fix name of logical classes
848195f to
058ef39
Compare
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 6, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Use assertStringContainsString when needed | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA This PR replaces deprecated assertContains to comparre string by the dedicated method `assertStringContainsString` Commits ------- 058ef39 Use assertStringContainsString when needed
This was referenced Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces deprecated assertContains to comparre string by the dedicated method
assertStringContainsString