[Validator] Set Length::$allowEmptyString to false when a NotBlank contraint is defined #34081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntraint is defined
1e343a4 to
840f7e7
Compare
fabpot
approved these changes
Oct 23, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Oct 23, 2019
…NotBlank contraint is defined (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Set Length::$allowEmptyString to false when a NotBlank contraint is defined | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Since #31528, we are told to do this kind of changes to our entities: ```diff /** * @Assert\NotBlank() - * @Assert\Length(min="10") + * @Assert\Length(min="10", allowEmptyString=false) */ public $description; ``` But the `NotBlank` already says it - this is just boilerplate. More critically, this also means we cannot write annotations that are compatible with 3.4, 4.4 and 5.0 at the same time, making FC/BC hard. By setting `Length::$allowEmptyString` to `false` when a `NotBlank` contraint is defined, we fix both issues. /cc @ogizanagi Commits ------- 840f7e7 [Validator] Set Length::$allowEmptyString to false when a NotBlank contraint is defined
nicolas-grekas
added a commit
that referenced
this pull request
Nov 21, 2019
…as-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Form] group constraints when calling the validator | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of #34081 Spotted during the workshop at SymfonyCon, while trying to fix deprecation notices on symfony-demo: the Form component currently passes constraints one by one for validation, effectively preventing the validator from taking care of cross-constraints dependencies. This PR fixes it. This will prevent ppl from having to fix things like > Using the "Symfony\Component\Validator\Constraints\Length" constraint with the "min" option without setting the "allowEmptyString" one is deprecated and defaults to true. In 5.0, it will become optional and default to false. Commits ------- d15f77f [Form] group constraints when calling the validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #31528, we are told to do this kind of changes to our entities:
/** * @Assert\NotBlank() - * @Assert\Length(min="10") + * @Assert\Length(min="10", allowEmptyString=false) */ public $description;But the
NotBlankalready says it - this is just boilerplate. More critically, this also means we cannot write annotations that are compatible with 3.4, 4.4 and 5.0 at the same time, making FC/BC hard.By setting
Length::$allowEmptyStringtofalsewhen aNotBlankcontraint is defined, we fix both issues./cc @ogizanagi