diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/Functional/JsonLoginTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/Functional/JsonLoginTest.php index 67b181d1a9b9a..e5dd7c18ed95b 100644 --- a/src/Symfony/Bundle/SecurityBundle/Tests/Functional/JsonLoginTest.php +++ b/src/Symfony/Bundle/SecurityBundle/Tests/Functional/JsonLoginTest.php @@ -70,6 +70,6 @@ public function testDefaultJsonLoginBadRequest() $this->assertSame(400, $response->getStatusCode()); $this->assertSame('application/json', $response->headers->get('Content-Type')); - $this->assertSame(['title' => 'Bad Request', 'status' => 400, 'detail' => 'Invalid JSON.'], json_decode($response->getContent(), true)); + $this->assertSame(['title' => 'Bad Request', 'status' => 400], json_decode($response->getContent(), true)); } } diff --git a/src/Symfony/Component/ErrorRenderer/ErrorRenderer/JsonErrorRenderer.php b/src/Symfony/Component/ErrorRenderer/ErrorRenderer/JsonErrorRenderer.php index 52bc37f833977..46e3c28c1adbc 100644 --- a/src/Symfony/Component/ErrorRenderer/ErrorRenderer/JsonErrorRenderer.php +++ b/src/Symfony/Component/ErrorRenderer/ErrorRenderer/JsonErrorRenderer.php @@ -43,9 +43,9 @@ public function render(FlattenException $exception): string $content = [ 'title' => $exception->getTitle(), 'status' => $exception->getStatusCode(), - 'detail' => $exception->getMessage(), ]; if ($debug) { + $content['detail'] = $exception->getMessage(); $content['exceptions'] = $exception->toArray(); } diff --git a/src/Symfony/Component/ErrorRenderer/ErrorRenderer/TxtErrorRenderer.php b/src/Symfony/Component/ErrorRenderer/ErrorRenderer/TxtErrorRenderer.php index e44d2a4a58270..f5588605ea2fd 100644 --- a/src/Symfony/Component/ErrorRenderer/ErrorRenderer/TxtErrorRenderer.php +++ b/src/Symfony/Component/ErrorRenderer/ErrorRenderer/TxtErrorRenderer.php @@ -41,9 +41,10 @@ public function render(FlattenException $exception): string $debug = $this->debug && ($exception->getHeaders()['X-Debug'] ?? true); $content = sprintf("[title] %s\n", $exception->getTitle()); $content .= sprintf("[status] %s\n", $exception->getStatusCode()); - $content .= sprintf("[detail] %s\n", $exception->getMessage()); if ($debug) { + $content .= sprintf("[detail] %s\n", $exception->getMessage()); + foreach ($exception->toArray() as $i => $e) { $content .= sprintf("[%d] %s: %s\n", $i + 1, $e['class'], $e['message']); foreach ($e['trace'] as $trace) { diff --git a/src/Symfony/Component/ErrorRenderer/ErrorRenderer/XmlErrorRenderer.php b/src/Symfony/Component/ErrorRenderer/ErrorRenderer/XmlErrorRenderer.php index 7a79bba85755e..4a678989200fd 100644 --- a/src/Symfony/Component/ErrorRenderer/ErrorRenderer/XmlErrorRenderer.php +++ b/src/Symfony/Component/ErrorRenderer/ErrorRenderer/XmlErrorRenderer.php @@ -42,12 +42,14 @@ public function render(FlattenException $exception): string { $debug = $this->debug && ($exception->getHeaders()['X-Debug'] ?? true); $title = $this->escapeXml($exception->getTitle()); - $message = $this->escapeXml($exception->getMessage()); $statusCode = $this->escapeXml($exception->getStatusCode()); $charset = $this->escapeXml($this->charset); $exceptions = ''; + $message = ''; if ($debug) { + $message = ''.$this->escapeXml($exception->getMessage()).''; + $exceptions .= ''; foreach ($exception->toArray() as $e) { $exceptions .= sprintf('', $e['class'], $this->escapeXml($e['message'])); @@ -71,7 +73,7 @@ public function render(FlattenException $exception): string {$title} {$statusCode} - {$message} + {$message} {$exceptions} EOF; diff --git a/src/Symfony/Component/ErrorRenderer/Tests/Command/DebugCommandTest.php b/src/Symfony/Component/ErrorRenderer/Tests/Command/DebugCommandTest.php index 383de253e139d..6c0a1f9996232 100644 --- a/src/Symfony/Component/ErrorRenderer/Tests/Command/DebugCommandTest.php +++ b/src/Symfony/Component/ErrorRenderer/Tests/Command/DebugCommandTest.php @@ -56,8 +56,7 @@ public function testFormatArgument() $this->assertSame(<<render() returns the TXT content WITH stack traces in debug mode' => [ diff --git a/src/Symfony/Component/ErrorRenderer/Tests/ErrorRenderer/XmlErrorRendererTest.php b/src/Symfony/Component/ErrorRenderer/Tests/ErrorRenderer/XmlErrorRendererTest.php index d79b147cde9b5..b79fd81d06584 100644 --- a/src/Symfony/Component/ErrorRenderer/Tests/ErrorRenderer/XmlErrorRendererTest.php +++ b/src/Symfony/Component/ErrorRenderer/Tests/ErrorRenderer/XmlErrorRendererTest.php @@ -43,7 +43,7 @@ public function getRenderData(): iterable Internal Server Error 500 - Foo + XML; diff --git a/src/Symfony/Component/HttpKernel/Tests/Controller/ErrorControllerTest.php b/src/Symfony/Component/HttpKernel/Tests/Controller/ErrorControllerTest.php index bc37a0e15ecae..83c429e876995 100644 --- a/src/Symfony/Component/HttpKernel/Tests/Controller/ErrorControllerTest.php +++ b/src/Symfony/Component/HttpKernel/Tests/Controller/ErrorControllerTest.php @@ -61,7 +61,7 @@ public function getInvokeControllerDataProvider() $request, FlattenException::createFromThrowable(new \Exception('foo')), 500, - '{"title": "Internal Server Error","status": 500,"detail": "foo"}', + '{"title": "Internal Server Error","status": 500}', ]; $request = new Request(); @@ -70,7 +70,7 @@ public function getInvokeControllerDataProvider() $request, FlattenException::createFromThrowable(new HttpException(405, 'Invalid request.')), 405, - '{"title": "Method Not Allowed","status": 405,"detail": "Invalid request."}', + '{"title": "Method Not Allowed","status": 405}', ]; $request = new Request(); @@ -79,7 +79,7 @@ public function getInvokeControllerDataProvider() $request, FlattenException::createFromThrowable(new HttpException(405, 'Invalid request.')), 405, - '{"title": "Method Not Allowed","status": 405,"detail": "Invalid request."}', + '{"title": "Method Not Allowed","status": 405}', ]; $request = new Request();