[FrameworkBundle] Disallow WebProfilerBundle < 4.4 #34369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Nov 13, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #34364 |
| License | MIT |
| Doc PR | N/A |
fabpot
approved these changes
Nov 14, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Nov 14, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Disallow WebProfilerBundle < 4.4 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34364 | License | MIT | Doc PR | N/A Commits ------- 3d2b589 [FrameworkBundle] Disallow WebProfilerBundle < 4.4.
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] disallow FrameworkBundle 4.4+ | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Since #34619 (merged in 4.4.1) the request stack can no longer be passed as an argument to the `HtmlErrorRenderer` constructor. However, FrameworkBundle 4.4 refuses to be used with WebProfilerBundle 3.4 since #34369 (merged in 4.4.0-RC1). Commits ------- ad45e9c disallow FrameworkBundle 4.4+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.