Skip to content

States that the HttpClient provides a Http Async implementation #34435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

Taluu
Copy link
Contributor

@Taluu Taluu commented Nov 18, 2019

Q A
Branch? 4.4
Bug fix? no (not really)
New feature? no (not really)
Deprecations? no
Tickets ~
License MIT
Doc PR ~

Add in the composer.json of the HttpClient that it now provides an implementation for the php-http/async-client-implementation virtual package, as @Nyholm did the implementation on the HttpPlug bridge in #33743.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Nov 18, 2019
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Taluu Taluu force-pushed the http-client/provides-async branch from d05558f to 8a460ce Compare November 18, 2019 12:47
@fabpot
Copy link
Member

fabpot commented Nov 19, 2019

Thank you @Taluu.

fabpot added a commit that referenced this pull request Nov 19, 2019
…ntation (Taluu)

This PR was merged into the 4.4 branch.

Discussion
----------

States that the HttpClient provides a Http Async implementation

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no (not really)
| New feature?  | no (not really)
| Deprecations? | no
| Tickets       | ~
| License       | MIT
| Doc PR        | ~

Add in the composer.json of the HttpClient that it now provides an implementation for the `php-http/async-client-implementation` virtual package, as @Nyholm did the implementation on the HttpPlug bridge in #33743.

Commits
-------

8a460ce States that the HttpClient provides a Http Async implementation
@fabpot fabpot merged commit 8a460ce into symfony:4.4 Nov 19, 2019
@Taluu Taluu deleted the http-client/provides-async branch July 6, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants