Skip to content

Added context to exceptions thrown in apply method #34457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2019
Merged

Added context to exceptions thrown in apply method #34457

merged 1 commit into from
Nov 24, 2019

Conversation

koenreiniers
Copy link
Contributor

@koenreiniers koenreiniers commented Nov 19, 2019 •
edited by lyrixx
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

During the workflow and state machines workshop at SymfonyCon, we noticed that the context in the apply method was not passed to the exceptions that are thrown. This could prove to be convenient for debugging purposes.

@koenreiniers koenreiniers requested a review from lyrixx as a code owner November 19, 2019 15:37
@ogizanagi ogizanagi added this to the next milestone Nov 19, 2019
lyrixx
lyrixx approved these changes Nov 23, 2019
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Could you add a note in the CHANGELOG. This will be in Symfony 5.1

@koenreiniers
Copy link
Contributor Author

koenreiniers commented Nov 23, 2019 •
edited
Loading

👍

Could you add a note in the CHANGELOG. This will be in Symfony 5.1

Yes, added it.

@fabpot
Copy link
Member

fabpot commented Nov 24, 2019

Thank you @koenreiniers.

@fabpot fabpot closed this in 692d0e7 Nov 24, 2019
@fabpot fabpot merged commit 8f86c33 into symfony:master Nov 24, 2019
@fabpot fabpot mentioned this pull request Nov 24, 2019
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Workflow
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@koenreiniers @fabpot @lyrixx @nicolas-grekas @ogizanagi @carsonbot