[HttpKernel] drop return type declaration #34516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configured memory limit can exceed the range that can be represented by an integer.
fancyweb
approved these changes
Nov 22, 2019
chalasr
approved these changes
Nov 22, 2019
yceruto
approved these changes
Nov 22, 2019
fabpot
approved these changes
Nov 22, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 22, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] drop return type declaration | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34508 | License | MIT | Doc PR | The configured memory limit can exceed the range that can be represented by an integer. Commits ------- 9368502 drop return type declaration
|
Will this be commited for v5.0 also ? |
|
Yes, we merge branches up regularly. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 19, 2021
… (LukeTowers) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Drop int return type from parseFilesize() | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix [octobercms/october#5410](octobercms/october#5410) | License | MIT | Doc PR | Related: #34516, #34508, 9368502, octobercms/october#5410 Commits ------- a1b31f8 [HttpFoundation] Drop int return type from parseFilesize()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configured memory limit can exceed the range that can be represented
by an integer.