Skip to content

[DoctrineBridge] do not depend on the QueryBuilder from the ORM #34600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 25, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #34581
License MIT
Doc PR

@fabpot
Copy link
Member

fabpot commented Nov 30, 2019

Thank you @xabbuh.

fabpot added a commit that referenced this pull request Nov 30, 2019
…e ORM (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge] do not depend on the QueryBuilder from the ORM

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34581
| License       | MIT
| Doc PR        |

Commits
-------

6958d77 do not depend on the QueryBuilder from the ORM
@fabpot fabpot merged commit 6958d77 into symfony:4.4 Nov 30, 2019
@xabbuh xabbuh deleted the issue-34581 branch November 30, 2019 12:43
This was referenced Dec 1, 2019
fabpot added a commit that referenced this pull request Dec 5, 2019
…er() (HeahDude)

This PR was merged into the 5.0 branch.

Discussion
----------

[DoctrineBridge] Removed QueryBuilder type hint in getLoader()

| Q             | A
| ------------- | ---
| Branch?       | 5.0 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ~
| License       | MIT
| Doc PR        | ~
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->
Follows #34600.

Commits
-------

8621852 [DoctrineBridge] Removed QueryBuilder type hint in getLoader()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants