Restores preview mode support for Html and Serializer error renderers #34619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ea75f0 to
5be5f8f
Compare
nicolas-grekas
approved these changes
Nov 28, 2019
5be5f8f to
38493b3
Compare
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
…r renderers (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- Restores preview mode support for Html and Serializer error renderers | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34602 | License | MIT | Doc PR | - This restores the preview mode support for all error renderers. Commits ------- 38493b3 Add preview mode support for Html and Serializer error renderers
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] disallow FrameworkBundle 4.4+ | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Since #34619 (merged in 4.4.1) the request stack can no longer be passed as an argument to the `HtmlErrorRenderer` constructor. However, FrameworkBundle 4.4 refuses to be used with WebProfilerBundle 3.4 since #34369 (merged in 4.4.0-RC1). Commits ------- ad45e9c disallow FrameworkBundle 4.4+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the preview mode support for all error renderers.