[SecurityBundle] Properly escape regex in AddSessionDomainConstraintPass #34788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e49e523 to
de03cee
Compare
nicolas-grekas
approved these changes
Dec 4, 2019
bykclk
approved these changes
Dec 4, 2019
|
Thank you @fancyweb. |
chalasr
added a commit
that referenced
this pull request
Dec 6, 2019
…ConstraintPass (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Properly escape regex in AddSessionDomainConstraintPass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34774 | License | MIT | Doc PR | - `%s` should be escaped, so it is dumped as `%%s` (it ends up being properly unescaped at load time, so the passed value to the service is the same). Commits ------- de03cee [SecurityBundle] Properly escape regex in AddSessionDomainConstraintPass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%sshould be escaped, so it is dumped as%%s(it ends up being properly unescaped at load time, so the passed value to the service is the same).