[Form] Allowing plural message on extra data validation failure #34984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please fill in the PR template in the description? If this is a bug, the PR should target the lowest branch where the bung is found (see PR description templates for details). A test case would be nice also. Thanks. |
|
I will add tests in the next few days |
|
@popnikos Do you have time to add some tests? |
|
Sorry but I cannot spend sole times right now.
I will try next week.
Le ven. 10 janv. 2020 à 12:54, Fabien Potencier <notifications@github.com>
a écrit :
… @popnikos <https://github.com/popnikos> Do you have time to add some
tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34984?email_source=notifications&email_token=AE6ECQGMBTZ6AUBNZFOH4G3Q5BOV3A5CNFSM4J3AOKB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEITWGVA#issuecomment-573006676>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6ECQC6E7QLBH24ITGWNXTQ5BOV3ANCNFSM4J3AOKBQ>
.
|
|
@xabbuh I met some difficulties with my github to modify my branch and have wrongly done modification on my master (popnikos/symfony github repo) and just use a merge master into my patch-1 branch (the one attached to this PR) Could you please validate it anyway (because dthe |
xabbuh
approved these changes
Mar 24, 2020
When using allow_extra_fields feature (and set to false) with an extra_fields_message, this message may now support pluralization regarding count of extra fields (extra data). e.g. "extra field found|extra fields found"
fabpot
approved these changes
Mar 24, 2020
|
Thank you @popnikos. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using allow_extra_fields feature (and set to false) with an extra_fields_message, this message may now support pluralization regarding count of extra fields (extra data). e.g. "extra field found|extra fields found"