[HttpClient] Add portable HTTP/2 implementation based on Amp's HTTP client #35115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c81d7c1 to
40313c8
Compare
nicolas-grekas
commented
Dec 26, 2019
40313c8 to
17cee92
Compare
kelunik
reviewed
Dec 27, 2019
17cee92 to
a6dde3d
Compare
kelunik
reviewed
Dec 28, 2019
8b4f81a to
96b3fc5
Compare
|
Now with fixed redirection logic (not reusing the existing one from Amp because we want a different behavior that is consistent with curl+native) |
kelunik
reviewed
Dec 30, 2019
kelunik
reviewed
Dec 30, 2019
kelunik
reviewed
Dec 30, 2019
kelunik
reviewed
Dec 30, 2019
kelunik
reviewed
Dec 30, 2019
kelunik
reviewed
Dec 30, 2019
kelunik
reviewed
Dec 30, 2019
kelunik
reviewed
Dec 30, 2019
96b3fc5 to
287f2ba
Compare
287f2ba to
b0d6520
Compare
0713fbd to
e0537ca
Compare
100e79d to
ab72bba
Compare
fd7d7db to
787b074
Compare
|
PR is ready for final review! |
Wirone
reviewed
Mar 2, 2020
|
|
||
| /** | ||
| * @param array $defaultOptions Default requests' options | ||
| * @param int $maxHostConnections The maximum number of connections to open |
There was a problem hiding this comment.
Sorry for such minor comment, but I don't get how phpDoc works here. There are 2 missing arguments here while documented ones don't add any valuable information (arguments' names are self-descriptive, they are typed). For me only @see adds something valuable here.
There was a problem hiding this comment.
Thanks for the feedback, all arguments are now documented.
fabpot
approved these changes
Mar 2, 2020
|
Thank you @nicolas-grekas. |
stof
reviewed
Mar 2, 2020
| @@ -59,7 +59,10 @@ test_script: | |||
| - SET SYMFONY_PHPUNIT_SKIPPED_TESTS=phpunit.skipped | |||
| - copy /Y c:\php\php.ini-min c:\php\php.ini | |||
| - IF %APPVEYOR_REPO_BRANCH% neq master (rm -Rf src\Symfony\Bridge\PhpUnit) | |||
| - mv src\Symfony\Component\HttpClient\phpunit.xml.dist src\Symfony\Component\HttpClient\phpunit.xml | |||
There was a problem hiding this comment.
To run the tests for the component separately: they block when run concurrently with other components, and we don't care as this doesn't happen in practice.
fabpot
added a commit
that referenced
this pull request
Mar 16, 2020
…pHttpClient` when `amphp/http-client` is found but curl is not or too old (nicolas-grekas) This PR was merged into the 5.1-dev branch. Discussion ---------- [HttpClient] make `HttpClient::create()` return an `AmpHttpClient` when `amphp/http-client` is found but curl is not or too old | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follows #35115 Let's use `amphp/http-client` by default, after `curl` and before `fopen()`. Commits ------- 7991685 [HttpClient] made `HttpClient::create()` return an `AmpHttpClient` when `amphp/http-client` is found but curl is not or too old
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2024
…rately (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- add comment explaining why HttpClient tests are run separately | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT see #35115 and #58916 Commits ------- cbdb08a add comment explaining why HttpClient tests are run separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an
AmpHttpClient, which is an adapter betweenamphp/http-clientandsymfony/http-client-contracts.This is an early experiment for now, but it works already on the happy path:I have a local h2-intensive script, and while it's slower than CurlHttpClient, this performs quite well!This could provide a portable implementation of HTTP/2 \o/
/cc @kelunik FYI
Todo:
$response->toStream()Allow skipping the default interceptors in HttpClientBuilder amphp/http-client#241Fix CI kelunik/certificate#2