[DI] deferred exceptions in ResolveParameterPlaceHoldersPass #35151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/DependencyInjection/Compiler/ResolveParameterPlaceHoldersPass.php
Show resolved
Hide resolved
fabpot
approved these changes
Jan 7, 2020
|
@Islam93 Can you rebase on 3.4 and change the target of this PR accordingly? |
6b80750 to
b3a2173
Compare
|
@fabpot, should travis-ci and appveyor builds be restarted? |
fabpot
approved these changes
Jan 10, 2020
|
Thank you @Islam93. |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2020
…ss (Islam93) This PR was merged into the 3.4 branch. Discussion ---------- [DI] deferred exceptions in ResolveParameterPlaceHoldersPass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #30428 | License | MIT | Doc PR | n/a fixes case #30428 implemented as in AutowiringPass Commits ------- b3a2173 [DI] deferred exceptions in ResolveParameterPlaceHoldersPass
This was referenced Jan 21, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes case #30428
implemented as in AutowiringPass