[FrameworkBundle] Make sure one can use fragments.hinclude_default_template #35306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Jan 11, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Jan 12, 2020
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Jan 12, 2020
…_default_template (Nyholm) This PR was squashed before being merged into the 4.4 branch (closes #35306). Discussion ---------- [FrameworkBundle] Make sure one can use fragments.hinclude_default_template | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Using `framework.fragments.hinclude_default_template` is not possible in 4.4. You will always get an exception saying: > You cannot set both "templating.hinclude_default_template" and "fragments.hinclude_default_template", please only use "fragments.hinclude_default_template". That is because in [fragment_renderer.xml](https://github.com/symfony/symfony/blob/4.4/src/Symfony/Bundle/FrameworkBundle/Resources/config/fragment_renderer.xml#L8) we define the parameter `fragment.renderer.hinclude.global_template` to be an empty string, then in FrameworkExtension we are checking if it is null. This PR do a `!empty` check instead. I also added a test to show the bug. Commits ------- 25fd665 [FrameworkBundle] Make sure one can use fragments.hinclude_default_template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
framework.fragments.hinclude_default_templateis not possible in 4.4. You will always get an exception saying:That is because in fragment_renderer.xml we define the parameter
fragment.renderer.hinclude.global_templateto be an empty string, then in FrameworkExtension we are checking if it is null.This PR do a
!emptycheck instead. I also added a test to show the bug.