[Yaml] fix PHP const mapping keys using the inline notation #35318
Conversation
xabbuh
commented
Jan 13, 2020
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #35179 |
| License | MIT |
| Doc PR |
|
Thank you @xabbuh. |
…n (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Yaml] fix PHP const mapping keys using the inline notation | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35179 | License | MIT | Doc PR | Commits ------- 45461c7 fix PHP const mapping keys using the inline notation
|
hey @xabbuh will this make its way into the YAML component? Sorry, I'm not familiar with the release process. Thanks for fixing it! |
|
@rhift Yes, this change will be part of the next patch releases for 3.4, 4.3, 4.4 and 5.0 as well as future minor versions. |
| @@ -504,6 +504,11 @@ private static function parseMapping($mapping, $flags, &$i = 0, $references = [] | |||
| $isKeyQuoted = \in_array($mapping[$i], ['"', "'"], true); | |||
| $key = self::parseScalar($mapping, $flags, [':', ' '], $i, false, [], true); | |||
|
|
|||
| if ('!php/const' === $key) { | |||
There was a problem hiding this comment.
Shouldn't we check for self::$constantSupport first? /cc @xabbuh
There was a problem hiding this comment.
I think this is fine because evaluateScalar() (which is called now) does the check.
|
Hi there, thanks for this! I can get globally defined constants to work great, but I can't find a way to get class constants to work. Is this intended behavior? I've tried the following. !php/const \PATH\TO\Class::CONSTANT: "value"
!php/const "\PATH\TO\Class::CONSTANT": "value"The scope resolution operator ( Being able to use class constants as keys was what I was hoping for when submitting #35179. Any help would be appreciated. Thank you. =) |
|
@rhift If I don't miss anything, we have these cases covered with tests. Could you open a new issue please with some code that allows to reproduce so that we can see whether there is another bug or if there is something else going wrong? |