Skip to content

[PHPunit bridge] Provide current file as file path #35597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2020
Merged

[PHPunit bridge] Provide current file as file path #35597

merged 1 commit into from
Feb 5, 2020

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Feb 5, 2020

I failed to apply perfectly this comment:
#33820 (comment)
It should fix one failing test in the bridge.

Q A
Branch? 4.4
Bug fix? not for the end user
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

@greg0ire greg0ire changed the title Provide current file as file path [PHPunit bridge] Provide current file as file path Feb 5, 2020
@greg0ire
Copy link
Contributor Author

greg0ire commented Feb 5, 2020

Locally, I have the following:

PHPUnit 8.3.5 by Sebastian Bergmann and contributors.

Testing src/Symfony/Bridge/PhpUnit
..........S....................................................S. 65 / 71 ( 91%)
...S..                                                            71 / 71 (100%)

Time: 12.45 seconds, Memory: 23.04 MB

OK, but incomplete, skipped, or risky tests!
Tests: 71, Assertions: 147, Skipped: 3.
PHP Notice:  Undefined index: remaining selfCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104

Notice: Undefined index: remaining selfCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104
PHP Notice:  Undefined index: remaining directCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104

Notice: Undefined index: remaining directCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104
PHP Notice:  Undefined index: remaining indirectCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104

Notice: Undefined index: remaining indirectCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104
PHP Notice:  Undefined index: remaining selfCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104

Notice: Undefined index: remaining selfCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104
PHP Notice:  Undefined index: remaining directCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104

Notice: Undefined index: remaining directCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104
PHP Notice:  Undefined index: remaining indirectCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104

Notice: Undefined index: remaining indirectCount in /home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php on line 104

not great, but better than the outright failure I get without this commit.

@greg0ire greg0ire changed the base branch from master to 4.4 February 5, 2020 07:46
@greg0ire greg0ire closed this Feb 5, 2020
@greg0ire greg0ire reopened this Feb 5, 2020
@greg0ire
Copy link
Contributor Author

greg0ire commented Feb 5, 2020

The remaining failures seem to stem from a permission issue when attempting a call to mkdir.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Feb 5, 2020
@nicolas-grekas
Copy link
Member

Thank you @greg0ire.

nicolas-grekas added a commit that referenced this pull request Feb 5, 2020
@nicolas-grekas
bug #35597 [PHPunit bridge] Provide current file as file path (greg0ire)
b6acfae 
This PR was merged into the 4.4 branch.

Discussion
----------

[PHPunit bridge] Provide current file as file path

I failed to apply perfectly this comment:
#33820 (comment)
It should fix one failing test in the bridge.

| Q             | A
| ------------- | ---
| Branch?       |4.4
| Bug fix?      | not for the end user
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

d5302cb Provide current file as file path
@nicolas-grekas nicolas-grekas merged commit d5302cb into symfony:4.4 Feb 5, 2020
@greg0ire greg0ire deleted the fix-merge branch February 5, 2020 12:51
This was referenced Feb 29, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @nicolas-grekas @carsonbot