Skip to content

[DomCrawler] Rename UriExpander.php -> UriResolver #35667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

[DomCrawler] Rename UriExpander.php -> UriResolver #35667

merged 1 commit into from
Feb 11, 2020

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Feb 10, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets refs symfony/symfony-docs#13054 (comment)
License MIT
Doc PR symfony/symfony-docs#13054 // don't open a new issue in doc repo

@lyrixx lyrixx mentioned this pull request Feb 10, 2020
Merged
@nicolas-grekas nicolas-grekas added this to the next milestone Feb 10, 2020
@lyrixx lyrixx force-pushed the dom-crawler-resolve branch from ba30cb1 to a52736b Compare February 10, 2020 18:02
ro0NL
ro0NL reviewed Feb 10, 2020
View reviewed changes
src/Symfony/Component/DomCrawler/CHANGELOG.md Outdated
@@ -5,7 +5,7 @@ CHANGELOG
-----

* Added an internal cache layer on top of the CssSelectorConverter
* Added `UriExpander` to expand an URL according to another URL
* Added `UriResolved` to resolve an URI according to a base URI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UriResolver :)

OskarStark
OskarStark reviewed Feb 10, 2020
View reviewed changes
src/Symfony/Component/DomCrawler/UriResolver.php Outdated
{
/**
* Expand an URI according to a current Uri.
* Resolve an URI according to a base URI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResolveS

@fabpot fabpot force-pushed the dom-crawler-resolve branch from a52736b to 3217f81 Compare February 11, 2020 06:10
@fabpot
Copy link
Member

fabpot commented Feb 11, 2020

Thank you @lyrixx.

fabpot added a commit that referenced this pull request Feb 11, 2020
@fabpot
feature #35667 [DomCrawler] Rename UriExpander.php -> UriResolver (ly…
1b52d60 
…rixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[DomCrawler] Rename UriExpander.php -> UriResolver

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | refs symfony/symfony-docs#13054 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#13054 // don't open a new issue in doc repo

Commits
-------

3217f81 [DomCrawler] Rename UriExpander.php -> UriResolver
@fabpot fabpot merged commit 3217f81 into symfony:master Feb 11, 2020
@lyrixx lyrixx deleted the dom-crawler-resolve branch February 11, 2020 07:46
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark left review comments

@ro0NL ro0NL ro0NL left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
DomCrawler Feature Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@lyrixx @fabpot @nicolas-grekas @OskarStark @ro0NL @carsonbot