Fixed missing friendly error on call of getMimeType() #35807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2020
Arman-Hosseini
approved these changes
Feb 21, 2020
That would be a major breaking change and would break laravel/framework 6 LTS. |
|
Closing in favor of #35808 because the implementation is a bit simpler and also because it adds a missing changelog line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would actually be in favour for reverting this change entirely, as it is breaking. It breaks
laravel/framework's 7.x branch which depends onsymfony/http-foundation: ^5.0. When v5.1.0 comes out, it will be broken. I'd argue Laravel was not usingsymfony/mimeimplicitly, since it called code in http-foundation. It didn't make use of a non-direct dependency by bypassing http-foundation code. I think Symfony should wait until 6.0 before making this an optional dependency.