[WIP][Session] Added auto-extend capability #3654
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what exactly means "extend" in this context? |
|
@lsmith77 it's the term I've used to describe the problem in the referenced ticket. It seems that I'll still need to do some work for the CSRF token but I'll have to study the problem a bit more for that |
|
Should be solved in #3659 |
|
Corrected. |
|
I'll close this one then. Thanks @Drak for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Fixes the following tickets: #2171
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass:
Todo: Seems that this implementation breaks CSRF tokens so this will need to be fixed.
I think this should allow you to define an entry called: auto_extend in the parameters of a session in order to make the session automatically extend on each start.
ping @Drak to see if this is the way of doing it.