[FrameworkBundle] remove getProjectDir method from MicroKernelTrait #36721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the changelog also. |
I thought changelogs were autogenerated... |
|
Only the main changelog is. We maintain them per components. |
3696245 to
51697a3
Compare
Ah, I see. |
nicolas-grekas
approved these changes
May 6, 2020
xabbuh
approved these changes
May 6, 2020
1d51402 to
f2f3eba
Compare
fabpot
approved these changes
May 6, 2020
|
Thank you @garak. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove method added in trait, to be able to use same method in base kernel class.