-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] don't add the inputmode attribute on fields whose type is the same #36869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @fre5h WDYT? |
I rechecked it on iOS mobile browsers. Works well. I mean only |
Indeed it’s not a bug, nor a feature. It basically added code for nothing so I believe it is okay to remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(for 5.1)
Thank you @MatTheCat. |
These is no need to add the
inputmode
attribute on fields whosetype
is the same.From https://html.spec.whatwg.org/multipage/interaction.html#attr-inputmode
From https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode
As such there is no point in adding
inputmode
for those types.Symfony’s
UrlType
usesinputmode
only when thetype
has to betext
because thedefault_protocol
option is set.