Skip to content

[Notifier] Move configuration to PHP #37189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

szepczynski
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets #37186
License MIT

Move Notifier Component Container configuration to PHP

@szepczynski szepczynski changed the title [Notifier] Move configuration yo PHP [Notifier] Move configuration to PHP Jun 10, 2020
return static function (ContainerConfigurator $container) {
$container->services()
->set('notifier', Notifier::class)
->args([tagged_locator('notifier.channel', 'channel'), service('notifier.channel_policy')->ignoreOnInvalid()])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot here you go for the first usage of a tagged_* thing 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and there is tagged_iterator below

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #37198

@fabpot
Copy link
Member

fabpot commented Jun 11, 2020

Thank you @szepczynski.

@fabpot fabpot merged commit 131682f into symfony:master Jun 11, 2020
@xabbuh xabbuh added this to the next milestone Jun 11, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants