Skip to content

[Console] Make sure we pass a numeric array of arguments to call_user_func_array() #37774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2020
Merged

[Console] Make sure we pass a numeric array of arguments to call_user_func_array() #37774

merged 1 commit into from
Aug 9, 2020

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Aug 8, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

On php 8, the unit tests fail with the following error:

ArgumentCountError: array_merge() does not accept unknown named parameters

This PR should fix the issue.

@fabpot
Copy link
Member

fabpot commented Aug 9, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 83b1d71 into symfony:3.4 Aug 9, 2020
@derrabus derrabus deleted the bugfix/variadic-array-merge branch August 9, 2020 08:32
This was referenced Aug 31, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @fabpot @carsonbot