[FrameworkBundle] Make AbstractPhpFileCacheWarmer public #37951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 26, 2020
|
This should target master. |
fabpot
approved these changes
Aug 26, 2020
|
Thank you @ossinkine. |
3736d25 to
a0fb442
Compare
|
@nicolas-grekas if this will be released only in 5.2 we still can't use this in bundles which support LTS f.e. 3.4 because the warmer is still internal there |
|
@ossinkine we can because the code won't change in 3.4+: it's stable. |
|
Not sure why it wasn't merged lower. People are still discouraged to extend this on lower versions for no reason, while it is no longer internal in higher versions. This now requires workarounds on lower versions because of phpunit bridge failures. |
fabpot
added a commit
that referenced
this pull request
Sep 2, 2020
… (ossinkine) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Make AbstractPhpFileCacheWarmer public | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT The same as #37951 but with 3.4 as base branch, see doctrine/DoctrineBundle#1196 (comment) cc @nicolas-grekas Commits ------- b82d9a2 Make AbstractPhpFileCacheWarmer public
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the PhpArrayAdapter was a great feature. It has proven itself well in the production.
Actually, using the adapter is closely related to warming up the cache for it. FrameworkBundle has an AbstractPhpFileCacheWarmer for conveniently creating a custom warmer.
But using it outside of the FrameworkBundle becomes more complicated because it is marked as internal.
I propose making it public and allow it to be used outside of the FrameworkBundle.
For example, I've proposed to cache Doctrine metadata using PhpArrayAdapter and the implementation uses AbstractPhpFileCacheWarmer doctrine/DoctrineBundle#1196