Skip to content

[PHPUnitBridge] deprecations not disabled anymore when disabled=0 #38017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2020
Merged

[PHPUnitBridge] deprecations not disabled anymore when disabled=0 #38017

merged 1 commit into from
Sep 1, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Aug 31, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations?
Tickets
License MIT
Doc PR

According to the docs, disabled=1 turns off deprecations mode on phpunit-bridge. It's not totally true since deprecations are disabled as soon as disabled key is present in SYMFONY_DEPRECATIONS_HELPER. So if disabled=0 deprecations are still disabled.

Instead of updating the doc, this PR suggest to make disabled behavior consistent with verbose behavior, so:

  • disabled => deprecations disabled
  • disabled=0 => deprecations enabled
  • disabled=1 => deprecations disabled

@l-vo l-vo force-pushed the make_disabled_option_consistent_with_verbose branch from 76cf3d2 to 6967a11 Compare September 1, 2020 12:10
@l-vo l-vo force-pushed the make_disabled_option_consistent_with_verbose branch from 6967a11 to e8089b5 Compare September 1, 2020 13:06
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 1, 2020
@l-vo
[PHPUnitBridge] deprecations not enabled anymore when disabled=0
6908e3d 
Allow to pass 0 or 1 to "disabled" to be consistent with "verbose" key behavior
@l-vo l-vo force-pushed the make_disabled_option_consistent_with_verbose branch from e8089b5 to 6908e3d Compare September 1, 2020 13:29
@fabpot
Copy link
Member

fabpot commented Sep 1, 2020

Thank you @l-vo.

@fabpot fabpot mentioned this pull request Sep 1, 2020
Closed
@fabpot fabpot merged commit a060635 into symfony:master Sep 1, 2020
@l-vo l-vo deleted the make_disabled_option_consistent_with_verbose branch September 1, 2020 16:46
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@l-vo @fabpot @nicolas-grekas @carsonbot