Skip to content

[PhpUnitBridge] Adjust output parsing of CoverageListenerTrait for PHPUnit 9.3 #38071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2020

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Sep 5, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #37637, #37564
License MIT
Doc PR N/A

This PR makes CoverageListenerTrait pass with PHPUnit 9.3. It contains a backport of #38054.

The problem that is addressed here is that a one of the fixture classes is now included in the output despite having a coverage of zero. The test now accepts both cases:

  • The class is omitted from the output
  • The class appears with 0.00% coverage.

@fabpot
Copy link
Member

fabpot commented Sep 5, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 63eab44 into symfony:3.4 Sep 5, 2020
@derrabus derrabus deleted the bugfix/coverage-listener branch September 5, 2020 17:21
This was referenced Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants