Skip to content

[DI] fix ContainerBuilder on PHP8 #38091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38089
License MIT
Doc PR -

@fabpot
Copy link
Member

fabpot commented Sep 7, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 8e34978 into symfony:3.4 Sep 7, 2020
@nicolas-grekas nicolas-grekas deleted the di-fix-php8-args branch September 7, 2020 12:10
This was referenced Sep 27, 2020
@kanlukasz
Copy link

Is it possible that this patch will be in Ubuntu 20 - apt package php-symfony-dependency-injection ?
Many of us have problems with phpmyadmin apt because of this problem:

@derrabus
Copy link
Member

Report this to Debian/Ubuntu, please. We're not involved in their packaging process.

@kanlukasz
Copy link

For others who are also looking for it:
https://bugs.launchpad.net/ubuntu/+source/symfony/+bug/1932552

nicolas-grekas added a commit that referenced this pull request Jan 11, 2023
…on-autowired services (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[DependencyInjection] Fix support for named arguments on non-autowired services

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #48818
| License       | MIT
| Doc PR        | -

This fixes support for named arguments on non-autowired services as described in #48818.

Related to #43277 and #38091

Commits
-------

a899bed [DependencyInjection] Fix support for named arguments on non-autowired services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants