[VarExporter] unserialize() might throw an Exception on php 8 #38101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4b92eb to
a75896d
Compare
|
Do you have an exemple of that on php 8? Worth a test case? |
|
We have a failing test already, see https://travis-ci.org/github/symfony/symfony/jobs/724971294, line 5020. |
|
I'd prefer being very specific about the reason of the exception. Maybe using getFilename()? |
a75896d to
d9802da
Compare
|
Sounds like a good idea. I've added a check. |
d9802da to
65112e1
Compare
nicolas-grekas
approved these changes
Sep 8, 2020
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VarExporter attempts a deserialization in order to check if a given object can be exported in serialized form. On php 8, the
unserializecall might throw an exception that needs to be caught and converted to the expectedNotInstantiableTypeException.