Skip to content

[Console] work around disabled putenv() #38166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2020
Merged

[Console] work around disabled putenv() #38166

merged 1 commit into from
Sep 15, 2020

Conversation

sentisso
Copy link
Contributor

@sentisso sentisso commented Sep 12, 2020 •
edited by nicolas-grekas
Loading

If this is set to true, then putenv functions simply won't be run in this script, making this function usable on servers, where putenv is disabled

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#...

@fabpot
Copy link
Member

fabpot commented Sep 14, 2020

As nobody had this issue before, I'm wondering if we should really cover this case.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Sep 14, 2020
@nicolas-grekas nicolas-grekas changed the title add dontRunPutenv attribute [Console] add dontRunPutenv attribute Sep 14, 2020
@nicolas-grekas nicolas-grekas changed the title [Console] add dontRunPutenv attribute [Console] work around disabled putenv() Sep 15, 2020
@nicolas-grekas nicolas-grekas changed the base branch from master to 3.4 September 15, 2020 07:31
@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 3.4 Sep 15, 2020
@nicolas-grekas nicolas-grekas modified the milestones: 3.4, 4.4 Sep 15, 2020
@xabbuh xabbuh added the Console label Sep 15, 2020
@nicolas-grekas nicolas-grekas changed the base branch from 3.4 to 4.4 September 15, 2020 07:57
nicolas-grekas
nicolas-grekas approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR on 4.4 and made the changes to make this seamless.
OK on my side from a technical pov.

@lyrixx lyrixx removed their request for review September 15, 2020 09:56
@fabpot
Copy link
Member

fabpot commented Sep 15, 2020

Thank you @sentisso.

@fabpot fabpot merged commit e608d05 into symfony:4.4 Sep 15, 2020
This was referenced Sep 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@maxhelias maxhelias maxhelias approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Console Feature Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
7 participants
@sentisso @fabpot @nicolas-grekas @maxhelias @azjezz @xabbuh @carsonbot