[lock] Provides default implementation when store does not supports the behavior #38296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
commented
Sep 24, 2020
|
Don't miss updating changelog+upgrade files. |
fabpot
approved these changes
Sep 26, 2020
fcfe4ab to
575b391
Compare
|
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All stores does not provide the same behaviors. Some are blocking, some allows shared Locks, ...
Issue is: When people use
lockto use a behavior that is not supported by the store, they get anUnsuportedException, but they don't have any way to know if the store supports or not the behavior they want to use.ie: when using the FrameworkBundle
User (or bundle) can't use safely
$lock->acquire(true)or$lock->acquireRead().Given it's very easy to provide an fallback implementation to those behavior, this PR