Skip to content

[FrameworkBundle] disallow FrameworkBundle 4.4+ #38383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 2, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Since #34619 (merged in 4.4.1) the request stack can no longer be passed as an argument to the HtmlErrorRenderer constructor. However, FrameworkBundle 4.4 refuses to be used with WebProfilerBundle 3.4 since #34369 (merged in 4.4.0-RC1).

@xabbuh xabbuh force-pushed the html-error-renderer branch from c9db30b to ad45e9c Compare October 2, 2020 12:18
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 60bfdaa into symfony:3.4 Oct 2, 2020
@xabbuh xabbuh deleted the html-error-renderer branch October 2, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants