Skip to content

Add missing use statement #38578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

Add missing use statement #38578

merged 1 commit into from
Oct 15, 2020

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Oct 14, 2020 •
edited
Loading

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets /
License MIT
Doc PR /

The StoreInterface has been renamed into PersistingStoreInterface in 4.4, but people are allowed to use an old version of the Lock component with a recent version of the FrameworkBundle.

The StoreInterface is used here:

symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Line 1582 in 3e587d7

$storeDefinition = new Definition(interface_exists(StoreInterface::class) ? StoreInterface::class : PersistingStoreInterface::class);

@fabpot
Copy link
Member

fabpot commented Oct 15, 2020

Thank you @jderusse.

@fabpot fabpot merged commit 6bbab59 into symfony:5.1 Oct 15, 2020
@jderusse jderusse deleted the fwb-use branch October 15, 2020 10:01
This was referenced Oct 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @fabpot @carsonbot