[DoctrineBridge] Convert values to Rfc4122 before inserting them into the database #38600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 16, 2020
|
Thank you @KDederichs. |
ccb8086 to
fd3a6e8
Compare
fabpot
added a commit
that referenced
this pull request
Oct 17, 2020
This PR was merged into the 5.x branch. Discussion ---------- [DoctrinBridge] make Uid types stricter | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Reviewing #38600 made me realize we don't need to deal with converting strings to db values. We should only support converting actual `AbstractUid` instances in the DB. Also, the binary types should *not* extend `GuidType`. Commits ------- ba31d0e [DoctrinBridge] make Uid types stricter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats the ULID into RFC4211 before inserting it into the database to avoid insertion failure on Postgres due to not recognized formating.