Skip to content

[String] fix slicing in UnicodeString #38659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

[String] fix slicing in UnicodeString #38659

merged 1 commit into from
Oct 21, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Spotted while reviewing symfony/polyfill#297

@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Oct 21, 2020
@derrabus
Copy link
Member

Do we need to bump symfony/polyfill-intl-grapheme for this to work?

@nicolas-grekas
Copy link
Member Author

Do we need to bump symfony/polyfill-intl-grapheme for this to work?

nope, that's independant

@derrabus
Copy link
Member

Thank you Nicolas.

@derrabus derrabus merged commit 29684ac into symfony:5.1 Oct 21, 2020
@nicolas-grekas nicolas-grekas deleted the s-fix branch October 21, 2020 16:37
This was referenced Oct 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed String
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @derrabus @stof @carsonbot