[RateLimiter] Moved classes implementing LimiterInterface to a new namespace #38664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cef430 to
c9d5801
Compare
stof
approved these changes
Oct 22, 2020
stof
reviewed
Oct 22, 2020
src/Symfony/Component/RateLimiter/Tests/Strategy/TokenBucketLimiterTest.php
Outdated
Show resolved
Hide resolved
jderusse
reviewed
Oct 22, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
javiereguiluz
approved these changes
Oct 22, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
6468960 to
7fd65bc
Compare
|
Failure is related, isn't it? |
|
Yes, they are. Im working on it |
|
The tests looks much happyr now. It is ready for merge. |
wouterj
approved these changes
Oct 24, 2020
src/Symfony/Bundle/SecurityBundle/Tests/Functional/FormLoginTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/RateLimiter/Policy/TokenBucketLimiter.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/RateLimiter/Policy/TokenBucketLimiter.php
Outdated
Show resolved
Hide resolved
2173882 to
1e6cea5
Compare
|
Thank you @Nyholm. |
|
Thank you for the reviews and merge! |
Merged
fabpot
added a commit
that referenced
this pull request
Mar 13, 2023
…in XSD (MatTheCat) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Rename limiter’s `strategy` to `policy` in XSD | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #49671 | License | MIT | Doc PR | N/A #38664 renamed `strategy` to `policy` but did not update the XSD. Commits ------- c19711c [FrameworkBundle] Rename limiter’s `strategy` to `policy` in XSD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we release the RateLimit component.
I think it would be a good idea to put the 7 classes that belongs to a specific strategy in their own "Policy" namespace. It is very likely that it will be more strategies in the future and the
Symfony\Component\RateLimiternamespace is crowed as it is.I decided not to put the
CompoundLimiterin this namespace as it is not a strategy.