[PropertyInfo] Dont try to set null when argument is not nullable #38920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test |
|
If it's a bug fix, shouldn't it target 4.4? |
jderusse
reviewed
Oct 31, 2020
Last time I checked, the code was very different in 4.4 and 5.1. I can check again later. |
xabbuh
reviewed
Nov 2, 2020
|
@Nyholm Can you finish this one? I think it should go in 5.2. |
8a750ce to
756b9bc
Compare
Nyholm
commented
Feb 15, 2021
|
@Nyholm What's the status here? |
|
@Nyholm Sorry to ping you again on this one :) |
|
I thought i would patch a simple bug. But Im not sure this is needed. I dont even remember what I did to find this bug. Im closing this since it has not been a priority for me (or anyone else) to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will break up #38800 into two smaller pieces.
If there is a method
setPreviousException(Throwable $t)and we try to unserialise a value of ['previousException'=>null], we should not try to invoke this setter. It will cause an error.