[Messenger] Test generated SQL #39214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Nov 29, 2020
src/Symfony/Component/Messenger/Tests/Transport/Doctrine/ConnectionTest.php
Outdated
Show resolved
Hide resolved
jderusse
approved these changes
Nov 29, 2020
OskarStark
reviewed
Dec 5, 2020
|
|
||
| yield 'SQL Server' => [ | ||
| new SQLServer2012Platform(), | ||
| 'SELECT m.* FROM messenger_messages m WITH (UPDLOCK, ROWLOCK) WHERE (m.delivered_at is null OR m.delivered_at < ?) AND (m.available_at <= ?) AND (m.queue_name = ?) ORDER BY available_at ASC OFFSET 0 ROWS FETCH NEXT 1 ROWS ONLY ', |
There was a problem hiding this comment.
Does it really generate white spaces at the end? 😄
There was a problem hiding this comment.
Yes. I know where that happens and could apply a trim there, but it felt unnecessary. WDYT?
fba5e83 to
1f1b62a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #39166.
This is an attempt to the SQL generated by the
Symfony\Component\Messenger\Transport\Doctrine\Connection::get()method. The challange was to create a locking SELECT statement, taking into account the different ways to create a lock in different SQL dialects.This test verifies if the correct lock statements are generated for MySQL and SQL Server.