Skip to content

[Mime] Leverage PHP 8's detection of CSV files #39252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2020
Merged

[Mime] Leverage PHP 8's detection of CSV files #39252

merged 1 commit into from
Dec 5, 2020

Conversation

derrabus
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #39237
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 4.4 milestone Nov 30, 2020
@derrabus derrabus mentioned this pull request Nov 30, 2020
Closed
fabpot
fabpot requested changes Dec 5, 2020
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to add application/csv to the reverse map

@derrabus
Copy link
Member Author

derrabus commented Dec 5, 2020

Done!

@fabpot
Copy link
Member

fabpot commented Dec 5, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 4a2946b into symfony:4.4 Dec 5, 2020
@derrabus derrabus deleted the bugfix/mime-csv branch December 5, 2020 08:52
This was referenced Dec 18, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Bug Mime Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @fabpot @jderusse @carsonbot