[Security] fix #39249, default entry_point compiler pass was returning too early #39261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturning too early
307572d to
c377805
Compare
wouterj
approved these changes
Dec 1, 2020
chalasr
approved these changes
Dec 1, 2020
|
You are welcome, with as many contributions you do that's fair :) There's another issue in 5.2.0 security, I'm working an issue and a patch on it, to come in a few minutes too. |
|
Good catch, thanks @romaricdrigon. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
returninstead ofcontinuewas making compiler pass return after the first firewall. Hence subsequents firewalls never had a default entrypoint set.This issue would occur with all firewalls, with any type of authenticator, though I saw it first with
http_basic- because it is a bit more opaque and harder to debug.