Skip to content

[Notifier] [Free Mobile] Fix wrong scheme in mapping #39456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2020
Merged

[Notifier] [Free Mobile] Fix wrong scheme in mapping #39456

merged 1 commit into from
Dec 12, 2020

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Dec 11, 2020 •
edited
Loading

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets ---
License MIT
Doc PR ---

The scheme is freemobile, not free-mobile

For reference:

symfony/src/Symfony/Component/Notifier/Bridge/FreeMobile/FreeMobileTransportFactory.php

Lines 41 to 43 in 134af39

if ('freemobile' === $scheme) {
return new FreeMobileTransport($login, $password, $phone, $this->client, $this->dispatcher);
}

@carsonbot carsonbot added this to the 5.1 milestone Dec 11, 2020
@carsonbot carsonbot changed the title [Notifier][Free Mobile] Fix wrong scheme in mapping [Notifier] [Free Mobile] Fix wrong scheme in mapping Dec 11, 2020
@OskarStark OskarStark force-pushed the fix-mapping branch 2 times, most recently from eea99c8 to b986a1a Compare December 11, 2020 13:28
jderusse
jderusse approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for consistency with googlechat:// from the symfony/google-chat-notifier component

@fabpot
Copy link
Member

fabpot commented Dec 12, 2020

Thanks for fixing this bug @OskarStark.

@fabpot fabpot merged commit 7c7366a into symfony:5.1 Dec 12, 2020
This was referenced Dec 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi left review comments

@fabpot fabpot fabpot approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @fabpot @jderusse @ogizanagi @carsonbot