Skip to content

[Notifier] Fix parsing Dsn with empty user/password #39538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2020
Merged

[Notifier] Fix parsing Dsn with empty user/password #39538

merged 1 commit into from
Dec 18, 2020

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Dec 17, 2020 •
edited
Loading

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets ---
License MIT
Doc PR ---

Same like #39531, but for Notifier component.

I backported the DsnTest from 5.2 to 5.1

@carsonbot carsonbot added this to the 5.1 milestone Dec 17, 2020
@OskarStark
Copy link
Contributor Author

Ready to merge from my side 👍

@fabpot fabpot force-pushed the fix-dsn-notifier-5.1 branch from 4d3dd9a to a80409a Compare December 18, 2020 07:25
@fabpot
Copy link
Member

fabpot commented Dec 18, 2020

Thank you @OskarStark.

@fabpot fabpot merged commit 24334cb into symfony:5.1 Dec 18, 2020
@OskarStark OskarStark deleted the fix-dsn-notifier-5.1 branch December 18, 2020 07:28
This was referenced Dec 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bykclk bykclk bykclk requested changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @fabpot @bykclk @carsonbot