Skip to content

[FrameworkBundle] Fix NFS detection on macOs #39555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2020
Merged

[FrameworkBundle] Fix NFS detection on macOs #39555

merged 1 commit into from
Dec 18, 2020

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39552
License MIT
Doc PR -

@carsonbot carsonbot added this to the 5.2 milestone Dec 18, 2020
@Nyholm Nyholm mentioned this pull request Dec 18, 2020
Closed
chalasr
chalasr approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does fix the FrameworkBundle test suite on my macbook 👍
Thanks!

Nyholm
Nyholm approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried the steps to reproduce the bug defined in #39552, this patch will fix the issue.

@mnocon
Copy link

mnocon commented Dec 18, 2020

If you need another data point: this PR solves the issue on my Mac 👍

@derrabus
Copy link
Member

Good catch, thanks Jérémy.

@derrabus derrabus merged commit 7a7ded2 into symfony:5.2 Dec 18, 2020
@alongosz
Copy link

Thanks @jderusse 🎉

@fabpot fabpot mentioned this pull request Dec 18, 2020
Merged
@jderusse jderusse deleted the fix-isnfs branch December 24, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
7 participants
@jderusse @mnocon @derrabus @alongosz @Nyholm @chalasr @carsonbot