Skip to content

[VarDumper] fixed displaying "mixed" as "?mixed" #39629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2020
Merged

[VarDumper] fixed displaying "mixed" as "?mixed" #39629

merged 1 commit into from
Dec 26, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@carsonbot carsonbot added this to the 4.4 milestone Dec 26, 2020
@derrabus derrabus changed the title Handle failure when sending DATA [VarDumper] fixed displaying "mixed" as "?mixed" Dec 26, 2020
derrabus
derrabus approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I've build a test case locally to test your fix and found that the caster is also broken for nullable union types. I will submit a followup PR.

@derrabus
Copy link
Member

Good catch, thanks Nicolas.

@derrabus derrabus merged commit 018e33a into symfony:4.4 Dec 26, 2020
@derrabus derrabus mentioned this pull request Dec 26, 2020
Merged
@derrabus
Copy link
Member

Followup: #39631

derrabus added a commit that referenced this pull request Dec 26, 2020
@derrabus
bug #39631 [VarDumper] Fix display of nullable union return types (de…
0ed047f 
…rrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[VarDumper] Fix display of nullable union return types

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #39629 (review)
| License       | MIT
| Doc PR        | N/A

Commits
-------

efeb2dc [VarDumper] Fix display of nullable union return types.
@nicolas-grekas nicolas-grekas deleted the vd-mixed branch January 20, 2021 19:45
This was referenced Jan 27, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed VarDumper
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @derrabus @carsonbot